proposal: Ignore vendor directory

[candiduslynx]

Description

Please explain the changes you made here.

Checklist

• Code compiles correctly
• Run make fmt to fix inconsistent formats
• Run make lint to get lint errors and fix all of them
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary

[candiduslynx]

I have read the CLA Document and I hereby sign the CLA

[candiduslynx]

recheck

[sfc-gh-dszmolka]

#729

[candiduslynx]

@sfc-gh-dszmolka any chance of review/running the workflows?

[sfc-gh-dszmolka]

PRs posted in this repo are regularly reviewed by the driver team, cannot promise any estimated timeline though. Thank you for bearing with us !

[sfc-gh-igarish]

could you please add more details about this PR?

[candiduslynx]

Hi @sfc-gh-igarish!

The reasoning could be linked to #729.

Basically, it's not required to save the vendor inside the repo unless the codebase has some manual updates (replaces, etc).

Additionally, having this lot of files results in huge updates when it should've been only a small commit.
Example: #769

[zeroshade]

I agree with this personally! It will make updates of dependencies significantly easier going forward if we can get rid of the vendor directory entirely.

[candiduslynx]

@sfc-gh-igarish is there a chance to get this reviewed/merged?
One of the reasons for this proposal can be seen at the moment (conflicts over simple vendor changes, that should've been scoped to go.mod & go.sum files only)

[candiduslynx]

I have read the CLA Document and I hereby sign the CLA

[candiduslynx]

Hi @sfc-gh-igarish! Any chance on reviewing this?

[zeroshade]

@candiduslynx they will probably ask you to rebase this back up-to-date. So can you pre-emptively do that and let's hope we can get their attention 😄

[sfc-gh-igarish]

LGTM

[candiduslynx]

@sfc-gh-igarish thanks for the review!
Do I need to do something special to make CLA pass?

[sfc-gh-igarish]

@sfc-gh-igarish thanks for the review! Do I need to do something special to make CLA pass?

Let's wait. I will let you know.