Timestamp type #94
Merged
Timestamp type #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and get functions. Updated existing code to use new SF_TIMESTAMP type. Added a function to transform a column into a timestamp type. Added test case to test all get functions.
|
This PR only deals with receiving data from the C API using the SF_TIMESTAMP struct. A future PR will deal with input binding of the timestamp type. |
smtakeda
reviewed
Sep 25, 2018
| column->valuestring, | ||
| sfstmt->connection->timezone, | ||
| sfstmt->desc[idx - 1].scale)) { | ||
| case SF_DB_TYPE_TIMESTAMP_TZ: ; |
There was a problem hiding this comment.
is this semicolon required?
There was a problem hiding this comment.
Yes, C expects a statement after the case keyword (because its just a label, similar to goto), so I can't declare a variable until after there is a statement, which is just the semicolon.
This was referenced Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SF_TIMESTAMP type as well as associated timestamp creation and get functions. Updated existing code to use new SF_TIMESTAMP type. Added a function to transform a column into a timestamp type. Added test case to test all get functions.