Fix keep alive heartbeat not being initialized correctly #553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation tries to start the heartbeat before auth response is received, which causes either a null pointer exception or a 401 response depending on the timing of the network. Furthermore, because of the singleton pattern, the heartbeat thread never stops, using system resources unnecessarily.
Instead of using token validity in seconds, this PR uses CLIENT_SESSION_KEEP_ALIVE_HEARTBEAT_FREQUENCY, which is returned by the server upon setting CLIENT_SESSION_KEEP_ALIVE true. It also allows overriding this parameter.