update cats effect to v3 #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuwy
suggested changes
Apr 28, 2021
There was a problem hiding this comment.
Hi @gipeshka! Thanks for your interest in scala-lru-map! Unfortunatelly, I don't think this bump would work out as the other core dependency scalacache still on CE2 and these major versions are neither source or binary compatible.
|
Hm, I guess it should've failed during compilation. I was able to run tests and those were passing. Though you might be right, feel free to close this one. |
|
Yeah, I guess we use just very small subset of Cats Effect in the library, which hasn't caused any errors. But if someone brings both dependencies into their project - it would likely fail either runtime or compiletime. |
|
Closing in favor of #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.