Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.6.0 #47

Merged
merged 20 commits into from Feb 21, 2022
Merged

Release/0.6.0 #47

merged 20 commits into from Feb 21, 2022

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Feb 9, 2022

No description provided.

@pondzix pondzix force-pushed the release/0.6.0 branch 6 times, most recently from 4b0c6a3 to cb20c2d Compare February 10, 2022 09:12
@chuwy chuwy self-requested a review February 10, 2022 10:33
Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have really nothing to pick up on. Looks perfect!

Maybe just replace lib names to actual artifact names, like:

cats effect -> cats-effect

@pondzix pondzix force-pushed the release/0.6.0 branch 2 times, most recently from 27cb68c to f3206af Compare February 11, 2022 09:09
README.md Outdated
Comment on lines 96 to 97
[coveralls]: https://coveralls.io/github/snowplow/scala-lru-map?branch=master
[coveralls-image]: https://coveralls.io/repos/github/snowplow/scala-lru-map/badge.svg?branch=master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These badges are slightly wrong (noticed whilst trying to figure out why Coveralls is failing). Should be in snowplow-incubator.

[![Coverage Status](https://coveralls.io/repos/github/snowplow-incubator/scala-lru-map/badge.svg?branch=master)](https://coveralls.io/github/snowplow-incubator/scala-lru-map?branch=master)

@pondzix pondzix force-pushed the release/0.6.0 branch 11 times, most recently from 52ef92d to 34186a6 Compare February 11, 2022 15:40
@paulboocock
Copy link

I don't have much to add to this, besides trying to help with the secrets and coveralls. Things look good from that point of view 👍

@pondzix pondzix force-pushed the release/0.6.0 branch 7 times, most recently from f9f5795 to 7f6f688 Compare February 18, 2022 08:25
Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

309d1d5 also looks awesome - I honestly never fully understood how the previous implementation was working, now it's much clearer

@pondzix pondzix merged commit e60cd3b into master Feb 21, 2022
@pondzix pondzix deleted the release/0.6.0 branch February 21, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants