New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.6.0 #47
Release/0.6.0 #47
Conversation
4b0c6a3
to
cb20c2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have really nothing to pick up on. Looks perfect!
Maybe just replace lib names to actual artifact names, like:
cats effect
-> cats-effect
cb20c2d
to
7a97226
Compare
27cb68c
to
f3206af
Compare
README.md
Outdated
[coveralls]: https://coveralls.io/github/snowplow/scala-lru-map?branch=master | ||
[coveralls-image]: https://coveralls.io/repos/github/snowplow/scala-lru-map/badge.svg?branch=master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These badges are slightly wrong (noticed whilst trying to figure out why Coveralls is failing). Should be in snowplow-incubator
.
[![Coverage Status](https://coveralls.io/repos/github/snowplow-incubator/scala-lru-map/badge.svg?branch=master)](https://coveralls.io/github/snowplow-incubator/scala-lru-map?branch=master)
52ef92d
to
34186a6
Compare
34186a6
to
aaf1831
Compare
I don't have much to add to this, besides trying to help with the secrets and coveralls. Things look good from that point of view 👍 |
f9f5795
to
7f6f688
Compare
7f6f688
to
b55ca49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
309d1d5 also looks awesome - I honestly never fully understood how the previous implementation was working, now it's much clearer
b55ca49
to
e60cd3b
Compare
No description provided.