Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Remove VARCHAR and CHAR precision when loading from temporary table #54

Closed
chuwy opened this issue Jun 21, 2018 · 0 comments
Closed

Remove VARCHAR and CHAR precision when loading from temporary table #54

chuwy opened this issue Jun 21, 2018 · 0 comments
Assignees
Milestone

Comments

@chuwy
Copy link
Contributor

chuwy commented Jun 21, 2018

Loader loads data in two steps:

  1. Loads data from S3 into temporary single-OBJECT-column table
  2. Loads data from temporary table into atomic.events

During second step, it also performs extraction and casting to get the right property (e.g. enriched_data:event_version::VARCHAR(128)). But precision in unnecessary in this step, it adds another point of failure in a case where user mutated table manually.

Leaving aside a point that we should avoid mutating table manually, sometimes it can be necessary and in future version we're planning to provide a fine-grained approach with processing manifest.

@chuwy chuwy added this to the Version 0.4.0 milestone Oct 19, 2018
@chuwy chuwy changed the title Remove VARCHAR-precision when loading from temporary table Remove VARCHAR and CHAR precision when loading from temporary table Dec 21, 2018
@chuwy chuwy closed this as completed in 7e56d6a Jan 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants