-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of default AWS credentials chain #36
Comments
For use on ECS Fargate is a good reason to support this: https://andrew.hawker.io/writings/2020/02/10/snowplow-fargate-task-role/ |
I've tried setting this up in Fargate. I tried using
full error message:
There is some useful information in this aws forum reply
as a workaround you can add this
At this stage I have forked the repo and looking to see if I can add the default credentials support because all of the AWS documentation I have read suggest it should just work with a new session, which should default to using the credentials provider chain, which in the context of ECS/Fargate should discover the task metadata endpoint. I have a suspicion that it is the explicit use of the If the default works then my feeling is that the On the other hand, these properties in the cluster and playbook config files are part of the iglu schemas so removing them would imply a new schema version, which may not be worth it. If that's the case it's easy to just add another case to the I am happy to look at a PR for this, I've already set up the dev environment and found a few issues in the vagrant build as mentioned in #62 which I would also include. @chuwy I would appreciate your feedback and guidance on this. For now I am making some changes and testing anyway but I'd prefer to get a PR merged so I don't have to run a custom fork. |
I've made changes and added tests that are passing, I will test the executable in my environment and then submit a PR. I note that two unrelated tests failed before I made any changes, which I know how to fix. These are testing hashicorp consul related features:
Both errors are happening in the
I manually installed the latest version of consul (1.7.2) into the vagrant, and ran
The fix for this will be
That is not a long term fix, however. I think that this code should probably use |
PR added #63 |
@chuwy It would be awesome if someone at Snowplow could review the PR. We've been running a fork with that since April, using ECS/Fargate, and would prefer to run the official version. |
Right now we can use:
To extract credentials from environment variables, but we also can use more default approach using
default
AWS profile etc.The text was updated successfully, but these errors were encountered: