Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make conversion_window_start_date more configurable #27

Closed
agnessnowplow opened this issue Aug 14, 2023 · 0 comments · Fixed by #30
Closed

Make conversion_window_start_date more configurable #27

agnessnowplow opened this issue Aug 14, 2023 · 0 comments · Fixed by #30
Labels
category:other Related to other parts of the package or repo itself. priority:medium On the roadmap. type:enhancement New features or improvements to existing features.

Comments

@agnessnowplow
Copy link
Contributor

Currently the users have to manually specify the conversion_window_start_date, otherwise it is defaulted to the last 30 days. We should add a variable so that users could specify the last nth number of days to specify the start date automatically for frequent runs.
@agnessnowplow agnessnowplow added the type:enhancement New features or improvements to existing features. label Aug 14, 2023
@github-actions github-actions bot added the status:needs_triage Needs maintainer triage. label Aug 14, 2023
@rlh1994 rlh1994 added priority:medium On the roadmap. category:other Related to other parts of the package or repo itself. and removed status:needs_triage Needs maintainer triage. labels Aug 14, 2023
agnessnowplow added a commit that referenced this issue Aug 14, 2023
@agnessnowplow
Make conversion_window_start_date more configurable (Close #27)
55c01ce
@agnessnowplow agnessnowplow mentioned this issue Aug 14, 2023
Merged
4 tasks
agnessnowplow added a commit that referenced this issue Aug 16, 2023
@agnessnowplow
Make conversion_window_start_date more configurable (Close #27)
3d282a7
agnessnowplow added a commit that referenced this issue Aug 16, 2023
@agnessnowplow
Make conversion_window_start_date more configurable (Close #27)
7a08aaa
@agnessnowplow agnessnowplow mentioned this issue Aug 16, 2023
Merged
6 tasks
agnessnowplow added a commit that referenced this issue Aug 17, 2023
@agnessnowplow
Make conversion_window_start_date more configurable (Close #27)
031ce66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:other Related to other parts of the package or repo itself. priority:medium On the roadmap. type:enhancement New features or improvements to existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release/snowplow fractribution/0.3.4 snowplow/dbt-snowplow-fractribution
2 participants
@rlh1994 @agnessnowplow