Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to cwv about dupe prevention and possibly refactor in doing so #217

Closed
agnessnowplow opened this issue Jul 27, 2023 · 0 comments
Closed

Add test to cwv about dupe prevention and possibly refactor in doing so #217

agnessnowplow opened this issue Jul 27, 2023 · 0 comments
Labels
type:enhancement New features or improvements to existing features.

Comments

@agnessnowplow
Copy link
Collaborator

We have added new logic to avoid NULL values in measurement due to grouping sets: #215 but only tested the solution to work locally for Snowflake. The integration tests could also possibly be reduced to two, one for Snowflake and one for the rest (after changes have been made in the stg file to format the tstamps for Bigquery).
@agnessnowplow agnessnowplow added the type:enhancement New features or improvements to existing features. label Jul 27, 2023
@github-actions github-actions bot added the status:needs_triage Needs maintainer triage. label Jul 27, 2023
@rlh1994 rlh1994 removed the status:needs_triage Needs maintainer triage. label Aug 26, 2023
@rlh1994 rlh1994 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New features or improvements to existing features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlh1994 @agnessnowplow