Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicates in web vital measurements #215

Closed
agnessnowplow opened this issue Jul 27, 2023 · 0 comments · Fixed by #218
Closed

Prevent duplicates in web vital measurements #215

agnessnowplow opened this issue Jul 27, 2023 · 0 comments · Fixed by #218
Assignees
@agnessnowplow
Labels
status:needs_triage Needs maintainer triage. type:bug Bugs or weaknesses. The issue has to contain steps to reproduce.

Comments

@agnessnowplow
Copy link
Collaborator

Describe the bug

The test for unique_snowplow_web_vital_measurements_compound_key can fail in the rare case when geo_country is null. Such events either need to be excluded or handled via code differently.
@agnessnowplow agnessnowplow added the type:bug Bugs or weaknesses. The issue has to contain steps to reproduce. label Jul 27, 2023
@github-actions github-actions bot added the status:needs_triage Needs maintainer triage. label Jul 27, 2023
@agnessnowplow agnessnowplow self-assigned this Jul 27, 2023
agnessnowplow added a commit that referenced this issue Jul 27, 2023
@agnessnowplow
Prevent duplicates in web vital measurements (Close #215)
f7b00c6
@agnessnowplow agnessnowplow mentioned this issue Jul 27, 2023
Merged
5 tasks
agnessnowplow added a commit that referenced this issue Jul 27, 2023
@agnessnowplow
Prevent duplicates in web vital measurements (Close #215)
7694fe9
agnessnowplow added a commit that referenced this issue Jul 27, 2023
@agnessnowplow
Prevent duplicates in web vital measurements (Close #215)
d8a9710
@agnessnowplow agnessnowplow mentioned this issue Jul 27, 2023
Closed
agnessnowplow added a commit that referenced this issue Jul 27, 2023
@agnessnowplow
Prevent duplicates in web vital measurements (Close #215)
754b867
@agnessnowplow agnessnowplow mentioned this issue Jul 27, 2023
Merged
7 tasks
agnessnowplow added a commit that referenced this issue Jul 28, 2023
@agnessnowplow
Prevent duplicates in web vital measurements (Close #215)
02cb3ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agnessnowplow agnessnowplow

Labels
status:needs_triage Needs maintainer triage. type:bug Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release/snowplow web/0.15.2 snowplow/dbt-snowplow-web
1 participant
@agnessnowplow