Set UserAgent header in Pubsub publisher and consumer #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
approved these changes
Nov 11, 2023
spenes
force-pushed
the
feature/gcp-attribution
branch
2 times, most recently
from
5c76cd0
to
b65b47a
Compare
spenes
force-pushed
the
feature/gcp-attribution
branch
from
b65b47a
to
b18af90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets user-agent header in Pubsub publisher and consumer to get GCP attribution. We did same thing in the Collector as well. Implementation in the Collector can be checked for the reference.
Also, I've moved Pubsub config specs under Pubsub module because config tests under common-fs2 module doesn't pick up and test
application.confof Pubsub module.