enrich-kafka: add blob storage support #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
reviewed
Nov 16, 2023
...s/common-fs2/src/main/scala/com/snowplowanalytics/snowplow/enrich/common/fs2/config/io.scala
Show resolved
Hide resolved
istreeter
reviewed
Nov 16, 2023
istreeter
approved these changes
Nov 17, 2023
spenes
force-pushed
the
feature/azure-blob-storage-integration
branch
from
389b784
to
7e0554f
Compare
spenes
changed the title
spenes
force-pushed
the
feature/azure-blob-storage-integration
branch
2 times, most recently
from
9e2cd33
to
b18e2a7
Compare
spenes
force-pushed
the
feature/azure-blob-storage-integration
branch
from
b18e2a7
to
ccdc185
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main aim of this PR is adding Azure Blob Storage client to enrich-kafka. Since enrich-kafka is cloud agnostic, I've added support for GCS and S3 as well. Also, I've integrated Azure Blob Storage client to enrich-nsq.
While doing these changes, I've made a bit refactoring. Firstly, I've moved blob storage clients to their own module. Secondly, I've moved config tests to their own modules. With this way, tests pick up modules'
application.conffiles.