Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different types of authentication for azure blob storage #845

Merged
merged 1 commit into from Jan 2, 2024

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Dec 27, 2023

This PR makes azure blob storage more flexible regarding authentication methods. Now t's possible to configure multiple storage accounts (like before), but with:

  • no authentication at all. No credentials are used when accessing storage. Useful for public accounts.
  • authentication using default credentials chain. That's the method Enrich used previously for all configured accounts.
  • authentication using SAS token. Token is provided in configuration and NOT generated dynamically in application.

New configuration looks like:

    "azureStorage": {
      "accounts": [
        # Example public account with no auth
        { "name": "storageAccount1"},

        # Example private account using default auth chain -> https://learn.microsoft.com/en-us/java/api/com.azure.identity.defaultazurecredential?view=azure-java-stable
        { "name": "storageAccount2", "auth": { "type": "default"} },

        # Example private account using SAS token auth
        { "name": "storageAccount3",  "auth": { "type": "sas", "value": "tokenValue"}}
      ]
    }

Comparing to the old one:

    "azureStorage": {
      # Azure blob storage account names
      "storageAccountNames": ["storageAccount1", "storageAccount2"]
    }

@pondzix pondzix merged commit cc06fa2 into develop Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants