New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of application context #140
Conversation
"build": { | ||
"type": "string" | ||
}, | ||
"androidFlavor": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was going to be buildFlavor no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😳 yah. it was. Fixing.
I guess the other thing one could call it that might be slightly more generic would be |
Oh yah, I like |
Coming back to this cold 6 months later, "build" and "buildVariant" feel a bit unintuitive. |
Hey @jbeemster - the original genesis for this context was Android apps. Would it be possible to automatically generate this context for an Android app, or would it need to be manually set by the app author? What about for Objective-C? |
It would need to be setup as a Tracker option but all that information should be available for both Android and Objective-C. I am thinking it might be worthwhile exposing a Context object of sorts which handles all of the various contexts that we have popping up.. |
Sounds good - can you create tickets for both mobile trackers then @jbeemster ? |
From a Java/Scala/Clojure perspective, the obvious field missing is organization aka vendor. |
Consider grouping the build fields into a nested sub-object |
Spec looks good to me @alexanderdean. With iOS we always have a build number, so requiring that would be fine. I'm not sure why buildVariant is needed, given that we have the mobile_context? |
Thanks @TiernanKennedy. I think |
Hmm, should there be OS specific stuff in here? Part of me thinks there should just be the addition of |
The mobile context is intended to describe the mobile device which is hosting the app; the application context is intended to describe the app which is running the tracker - so application build and version details belong in the application context. We could potentially rename |
Ah I see what you mean now. Yeah then 👍 |
We're missing the application license as well... |
Should we add sourceRepository, sourceTag and sourceCommit too? |
I don't think we need either for a first release of the schema. |
@duncan has signed the Software Grant and Corporate Contributor License Agreement |
I'm not sure what I meant by application license.
Because of Redshift blocked schemas, the first release will be the only release for the foreseeable future. |
Pushing back to R97. @keanerobinson please let us know what do you think of it when you're back. |
Closing in favor of #847 |
As discussed in #136, an initial draft of an application context with
name
,version
,build
,androidFlavor
, andbuildIsRelease
properties.