Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft of application context #140

Closed
wants to merge 3 commits into from

Conversation

duncan
Copy link
Contributor

@duncan duncan commented Feb 27, 2015

As discussed in #136, an initial draft of an application context with name, version, build, androidFlavor, and buildIsRelease properties.

"build": {
"type": "string"
},
"androidFlavor": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was going to be buildFlavor no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳 yah. it was. Fixing.

@alexanderdean alexanderdean self-assigned this Feb 27, 2015
@duncan
Copy link
Contributor Author

duncan commented Feb 27, 2015

I guess the other thing one could call it that might be slightly more generic would be buildVariant... ?

@alexanderdean
Copy link
Member

Oh yah, I like buildVariant.

@alexanderdean
Copy link
Member

Coming back to this cold 6 months later, "build" and "buildVariant" feel a bit unintuitive.

@alexanderdean
Copy link
Member

Hey @jbeemster - the original genesis for this context was Android apps. Would it be possible to automatically generate this context for an Android app, or would it need to be manually set by the app author? What about for Objective-C?

@jbeemster
Copy link
Member

It would need to be setup as a Tracker option but all that information should be available for both Android and Objective-C. I am thinking it might be worthwhile exposing a Context object of sorts which handles all of the various contexts that we have popping up..

@alexanderdean
Copy link
Member

Sounds good - can you create tickets for both mobile trackers then @jbeemster ?

@alexanderdean
Copy link
Member

From a Java/Scala/Clojure perspective, the obvious field missing is organization aka vendor.

@alexanderdean
Copy link
Member

Consider grouping the build fields into a nested sub-object

@TiernanKennedy
Copy link

Spec looks good to me @alexanderdean.

With iOS we always have a build number, so requiring that would be fine.

I'm not sure why buildVariant is needed, given that we have the mobile_context?

@alexanderdean
Copy link
Member

Thanks @TiernanKennedy. I think buildVariant is an Android thing?

@TiernanKennedy
Copy link

Hmm, should there be OS specific stuff in here? Part of me thinks there should just be the addition of build and version in the mobile context. Is there a reason to keep them separate? @alexanderdean

@alexanderdean
Copy link
Member

The mobile context is intended to describe the mobile device which is hosting the app; the application context is intended to describe the app which is running the tracker - so application build and version details belong in the application context. We could potentially rename buildVariant to something less Android-flavoured...

@alexanderdean
Copy link
Member

@TiernanKennedy
Copy link

Ah I see what you mean now. Yeah then buildVariant does make sense.

👍

@alexanderdean
Copy link
Member

We're missing the application license as well...

@alexanderdean
Copy link
Member

Should we add sourceRepository, sourceTag and sourceCommit too?

@bogaert
Copy link

bogaert commented Feb 26, 2018

We're missing the application license as well...
Should we add sourceRepository, sourceTag and sourceCommit too?

I don't think we need either for a first release of the schema.

@snowplowcla
Copy link

@duncan has signed the Software Grant and Corporate Contributor License Agreement

@alexanderdean
Copy link
Member

I'm not sure what I meant by application license.

Should we add sourceRepository, sourceTag and sourceCommit too?

I don't think we need either for a first release of the schema.

Because of Redshift blocked schemas, the first release will be the only release for the foreseeable future.

@alexanderdean alexanderdean added this to the Release 96 milestone Aug 24, 2018
@chuwy
Copy link
Contributor

chuwy commented Sep 6, 2018

Pushing back to R97. @keanerobinson please let us know what do you think of it when you're back.

@chuwy chuwy modified the milestones: Release 96, Release 97 Sep 6, 2018
@chuwy
Copy link
Contributor

chuwy commented Sep 24, 2018

Closing in favor of #847

@chuwy chuwy closed this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants