Adding initial hyper t schemas. #1401
Conversation
| "maxLength": 255 | ||
| }, | ||
| "item_type": { | ||
| "type": "string", |
There was a problem hiding this comment.
Should this. be a required property or should we allow it to be null?
There was a problem hiding this comment.
So after discussing with the other guys we agree that the item type field should be required.
It is also a join key used in our data models so to ensure that users will use the correct values lest we break any downstream models we've also opted for making it an enum field.
There was a problem hiding this comment.
That makes sense! I just meant that if it is required then we should have it in the list of required properties (currently there is only item_id)? Otherwise it's in a weird state where we don't accept null for it but it can be missing from payload.
…ld in order entity to be a singular ID.
| "minimum": 0, | ||
| "maximum": 2147483647 | ||
| }, | ||
| "subtotal": { |
There was a problem hiding this comment.
I feel the subtotal, shipping_cost and tax belong in the /order/ schema. Am I right ?
There was a problem hiding this comment.
We think for purpose of analysing behaviour with events before an order is created it'll be helpful to have these fields with the cart entity, so worth to leave them in here as well as on the order/payment entities.
| @@ -0,0 +1,28 @@ | |||
| { | |||
| "description": "When the submit_search is completed, this event will be triggered along with the contexts view_collection (the viewing of the search results) and search (the search event parameters).", | |||
There was a problem hiding this comment.
Tempted to name it search_result.
There was a problem hiding this comment.
Since we have submit_search probably best to leave that naming convention as is. Also the name search_result denotes that the search returned with some result but it is possible to have searches that have no results.
…efinitions for local refs; added collection_id to click_item event.
…_trigger no longer accepts null; order payment_id now required; click_item collection_id now required; added more desc.
The table here lists which schema (event and entity) is currently implemented in which environment (Shopify app, DBT models and data gen app).