More resilient schema lookup #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happened to me once or twice that specs were running for a long time, and then it didn't pass b/c there was a problem with iglucentral connection. I don't have the exception at hand, and couldn't reproduce it, but I believe it was a flaky network connection or maybe iglucentral wasn't available. I've added `read_timeout` and simple retry in case it happens again. Hopefully this will make it more robust.
|
Thanks again, @sparrovv! This also makes it more consistent with canonical Scala Iglu client. |
|
@sparrovv has signed the Software Grant and Corporate Contributor License Agreement |
chuwy
approved these changes
Aug 14, 2017
sparrovv
commented
Aug 16, 2017
| begin | ||
| response = HTTParty.get(schema_uri) | ||
| response = HTTParty.get(schema_uri, timeout: 3) | ||
| rescue SocketError => _ |
There was a problem hiding this comment.
I'm just thinking that we might also want to retry on the SocketError 🤔
There was a problem hiding this comment.
I don't have a strong opinion on that. But leaning towards not retrying on the SocketError as this is rarely something that can be fixed by bigger delay.
|
Why only catch and retry on |
Closed
|
Cherry-picked to #14 . Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happened to me once or twice that specs were running for a long time,
and then they've failed b/c there was a problem with iglucentral
connection.
I don't have the exception at hand, and couldn't reproduce it now, but I believe it was a flaky network connection or maybe iglucentral wasn't available. I've added
read_timeoutand simple retry in case it happens again.Hopefully this will make it more robust.