Release/1.0.0 #117
Release/1.0.0 #117
Conversation
aldemirenes
force-pushed
the
release/1.0.0
branch
2 times, most recently
from
1754507
to
8ddf308
Compare
|
I've realized some problem with scoverage. It causes |
chuwy
force-pushed
the
release/1.0.0
branch
2 times, most recently
from
96df9e6
to
1061597
Compare
| @@ -15,7 +15,7 @@ deploy: | |||
| provider: script | |||
| script: ./.travis/deploy.sh $TRAVIS_TAG | |||
| on: | |||
| condition: '"${TRAVIS_SCALA_VERSION}" == "2.12.8" && "${TRAVIS_JDK_VERSION}" == "openjdk8"' | |||
| condition: '"${TRAVIS_SCALA_VERSION}" == "2.12.8"' | |||
There was a problem hiding this comment.
TBH, I don't even know why we need several version in the first place. SBT is responsible for cross-version test, not Travis.
| @@ -111,7 +112,7 @@ class RawValidationSpec extends Specification with DataTables { | |||
| val doubleError = CirceValidator.validate(doubleErrorInput, simpleSchemaResult) must beLeft( | |||
| doubleErrorExpected) | |||
|
|
|||
| nonString and missingKey and heterogeneusArray | |||
| nonString and missingKey and heterogeneusArray and doubleError | |||
There was a problem hiding this comment.
That's some very deep review.
.travis.yml
Outdated
| @@ -23,3 +23,4 @@ env: | |||
| - secure: R3N94P7noue7/K2KOLjfxNVZV6Eft2emrU0zfh/qbkAwW6CF6w3gjVxRJwBzOhrsy5W4SU7r18Dft9/YS1QQOKw5HuBGNKnVytJxhkHPRB7EE/KrDnlQ0uHK9LAlQnwQzb74+iyQv6ONcrCF1M7xEnnkst8buZp4zoB8JXUA8bM= | |||
| - secure: jh4RLrx+HoTmzgfvsxle8hWdAsz6m5M0qvaBu3VAGPnrM4NmRPyfyb08btlN+qLJOTEBilZGIKh+cYSE8NRJHXR+8iAKHikop8rOh6HqwaEl8A7SFy/Nx6RMys3Cy3yX5AVLHhgpu4absok4QlVplYhn2aK6EbYsM0VS1uyOztQ= | |||
| - secure: ZdJH16Iz79TTwPCha92BuekZP07QsLAxMqaG4liH45ncK4TE+xfEE0lAmt2SqonPodXDbx94cFwjTEum0xFsEOp1ASsz393i265+qVKT+WwumpMe1/4Ta9UF6bAZMBQSeikgW7Qnh7uN2DVUKJ9LNrCg3xlBReWeqJC/1AjD+TM= | |||
| - ENCRYPTION_LABEL: <placeholder> | |||
There was a problem hiding this comment.
Shouldn't this be removed if we're not using it?
On the other hand, should we be using it, to make the GH publishing consistent across projects?
There was a problem hiding this comment.
Yes! You're right - I'll add it properly.
Instructions for integrating ScalaDoc-GhPages can be found in here.