Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for gzip file format #43

Closed
wants to merge 4 commits into from
Closed

Support for gzip file format #43

wants to merge 4 commits into from

Conversation

kazjote
Copy link
Contributor

@kazjote kazjote commented Jul 8, 2015

I find LZO compressed protobuf file format very difficult to work with.

This Pull Request adds support for gzip file format. GZip format can only be used for Kinesis records coming from enriched stream.

@khalidjaz
Copy link

👍

@alexanderdean
Copy link
Member

Hey @kazjote ! Great idea and this PR looks good. @kazjote has signed the CLA.

One thing - it looks like this is branched off an earlier Kinesis S3 release (probably 0.2.1). Can you rebase off the latest release, 0.3.0?

@alexanderdean alexanderdean added this to the Version 0.4.0 milestone Jul 8, 2015
@kazjote
Copy link
Contributor Author

kazjote commented Jul 8, 2015

It's rebased now.

@alexanderdean
Copy link
Member

Thanks!

@alexanderdean alexanderdean mentioned this pull request Jul 24, 2015
Closed
jbeemster pushed a commit that referenced this pull request Aug 13, 2015
@kazjote @jbeemster
Added support for gzip file format (closes #43)
eb57eb0
@jbeemster jbeemster closed this in 1443a7e Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeemster jbeemster

Labels
enhancement
Projects
None yet
Milestone
Version 0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kazjote @khalidjaz @alexanderdean @jbeemster