Write records to Kinesis in a batch #32
base: master
Are you sure you want to change the base?
Conversation
Thanks, I'll have a look tomorrow 👍 |
Thanks! |
@kazjote has signed the Individual Contributor License Agreement. Thanks so much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
@@ -86,6 +86,7 @@ object KinesisTee extends Tee { | |||
content | |||
.map(transform) | |||
.filter(filter) | |||
.grouped(100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we have this parameter as a configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have update PR and made this configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 , could you open a pr against iglu-central too adding the 1-1-0 schema?
@BenFradet I can. However, I am not sure if it is really Iglu schema. According to https://github.com/snowplow/iglu/blob/master/README.md
but avro schema is not json-schema (however somehow similar). As far as I can see, there are at least differences in types (for example: "record", "int", "number"). I am not sure if anybody can use it with any json-schema validator. For example, it fails with this one: https://www.jsonschemavalidator.net/ Let me know if you still want to have avro schema in Iglu Central. If you do, I will create a PR. |
We have avro schemas in iglu central too like the one for 1-0-0: https://github.com/snowplow/iglu-central/tree/master/schemas/com.snowplowanalytics.kinesistee.config/Configuration/avro |
@BenFradet: Kacpers contributions should be covered by the LiveIntent corporate CLA. |
@kazjote has signed the Software Grant and Corporate Contributor License Agreement. Thanks so much |
@BenFradet Any chance to have this PR accepted and released? |
hey @christoph-buente , we're not maintaining this project anymore. I'll ask for it to be archived. |
Interesting, what are the proposed ways to filter streams for example for missing data or spider/bot traffic?
…________________________________
From: Ben Fradet <notifications@github.com>
Sent: Thursday, June 20, 2019 8:14:41 AM
To: snowplow/kinesis-tee
Cc: Christoph Bünte; Mention
Subject: Re: [snowplow/kinesis-tee] Write records to Kinesis in a batch (#32)
hey @christoph-buente<https://github.com/christoph-buente> , we're not maintaining this project anymore. I'll ask for it to be archived.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#32?email_source=notifications&email_token=AAAJBBTBUG5IOUMCD2XYGNLP3MN5DA5CNFSM4D7X4THKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYEMGFQ#issuecomment-503890710>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAAJBBTTGUMFKK5RFZVNPHTP3MN5DANCNFSM4D7X4THA>.
|
This fixes problem with Kinesis Tee performance. See #31.
Additionally specs are updated to work with awscala 0.5.9.