Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

Write records to Kinesis in a batch #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Write records to Kinesis in a batch #32

wants to merge 3 commits into from

Conversation

kazjote
Copy link

@kazjote kazjote commented Oct 18, 2017

This fixes problem with Kinesis Tee performance. See #31.

Additionally specs are updated to work with awscala 0.5.9.

@BenFradet BenFradet self-assigned this Oct 18, 2017
@BenFradet BenFradet self-requested a review October 18, 2017 16:15
@BenFradet
Copy link

Thanks, I'll have a look tomorrow 👍

@kazjote
Copy link
Author

kazjote commented Oct 18, 2017

Thanks!

@snowplowcla
Copy link

@kazjote has signed the Individual Contributor License Agreement. Thanks so much

Copy link

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@@ -86,6 +86,7 @@ object KinesisTee extends Tee {
content
.map(transform)
.filter(filter)
.grouped(100)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we have this parameter as a configuration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have update PR and made this configurable.

Copy link

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 , could you open a pr against iglu-central too adding the 1-1-0 schema?

@kazjote
Copy link
Author

kazjote commented Oct 19, 2017

@BenFradet I can. However, I am not sure if it is really Iglu schema. According to https://github.com/snowplow/iglu/blob/master/README.md

Iglu is a machine-readable, open-source schema repository for [JSON Schema] json-schema

but avro schema is not json-schema (however somehow similar). As far as I can see, there are at least differences in types (for example: "record", "int", "number"). I am not sure if anybody can use it with any json-schema validator. For example, it fails with this one: https://www.jsonschemavalidator.net/

Let me know if you still want to have avro schema in Iglu Central. If you do, I will create a PR.

@BenFradet
Copy link

We have avro schemas in iglu central too like the one for 1-0-0: https://github.com/snowplow/iglu-central/tree/master/schemas/com.snowplowanalytics.kinesistee.config/Configuration/avro

@christoph-buente
Copy link

@BenFradet: Kacpers contributions should be covered by the LiveIntent corporate CLA.

@snowplowcla
Copy link

@kazjote has signed the Software Grant and Corporate Contributor License Agreement. Thanks so much

@christoph-buente
Copy link

@BenFradet Any chance to have this PR accepted and released?

@BenFradet
Copy link

hey @christoph-buente , we're not maintaining this project anymore. I'll ask for it to be archived.

@christoph-buente
Copy link

christoph-buente commented Jun 20, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants