Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.7.0 #155

Merged
merged 20 commits into from Nov 11, 2019
Merged

0.7.0 #155

merged 20 commits into from Nov 11, 2019

Conversation

BenFradet
Copy link
Contributor

@BenFradet BenFradet commented Feb 28, 2019

  • hammock -> scalaj
  • new readme examples
  • final scala-lru-map version
  • changelog release date
  • publish doc
  • cla-bot

@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #155 into develop will decrease coverage by 0.58%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #155      +/-   ##
===========================================
- Coverage    91.36%   90.78%   -0.59%     
===========================================
  Files            3        6       +3     
  Lines          139      141       +2     
  Branches        10       10              
===========================================
+ Hits           127      128       +1     
- Misses          12       13       +1
Impacted Files Coverage Δ
...ain/scala/com.snowplowanalytics/forex/errors.scala 100% <100%> (ø)
.../scala/com.snowplowanalytics/forex/responses.scala 100% <100%> (ø)
...scala/com.snowplowanalytics/forex/ZonedClock.scala 66.66% <66.66%> (ø)
.../scala/com.snowplowanalytics/forex/Transport.scala 73.33% <73.33%> (ø)
...main/scala/com.snowplowanalytics/forex/Forex.scala 90.19% <89.47%> (-3.56%) ⬇️
.../scala/com.snowplowanalytics/forex/OerClient.scala 96.72% <95.83%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac01d9...964b93b. Read the comment docs.

@BenFradet BenFradet force-pushed the 0.7.0 branch 3 times, most recently from 874fd86 to 37bba51 Compare March 5, 2019 13:53
@BenFradet BenFradet requested a review from chuwy March 8, 2019 08:23
Copy link
Contributor

@chuwy chuwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one major concern around our Eval/IO evaluation model. I think we should prioritize the smoke testing with Spark to figure out if we chose the right path at all.

Another, much less important thought is that switching from constrained data constructors to constrained methods will be more inline with FP conventions.

Apart from that LGTM.

@dilyand dilyand force-pushed the 0.7.0 branch 2 times, most recently from e339c9d to c4ddf47 Compare November 8, 2019 21:00
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants