New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.7.0 #155
Conversation
BenFradet
commented
Feb 28, 2019
•
edited by dilyand
edited by dilyand
- hammock -> scalaj
- new readme examples
- final scala-lru-map version
- changelog release date
- publish doc
- cla-bot
Codecov Report
@@ Coverage Diff @@
## develop #155 +/- ##
===========================================
- Coverage 91.36% 90.78% -0.59%
===========================================
Files 3 6 +3
Lines 139 141 +2
Branches 10 10
===========================================
+ Hits 127 128 +1
- Misses 12 13 +1
Continue to review full report at Codecov.
|
874fd86
to
37bba51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one major concern around our Eval
/IO
evaluation model. I think we should prioritize the smoke testing with Spark to figure out if we chose the right path at all.
Another, much less important thought is that switching from constrained data constructors to constrained methods will be more inline with FP conventions.
Apart from that LGTM.
6da3e00
to
508ad82
Compare
416d2d1
to
ce6bdc8
Compare
e339c9d
to
c4ddf47
Compare