Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat #129

Merged
merged 2 commits into from
Aug 27, 2020
Merged

reformat #129

merged 2 commits into from
Aug 27, 2020

Conversation

lukeindykiewicz
Copy link
Contributor

There are two commits, one is for config changes - good to review, the other is just for reformatting the code.

@dilyand
Copy link
Contributor

dilyand commented Aug 26, 2020

Is the Travis build expected to fail for this PR?

Copy link
Contributor

@dilyand dilyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeindykiewicz lukeindykiewicz changed the base branch from master to develop August 27, 2020 18:21
@lukeindykiewicz
Copy link
Contributor Author

Thanks Dilyan, it was failing due to access key error. It's rebased on newest develop and should be green now.

@lukeindykiewicz lukeindykiewicz merged commit d29c9fe into develop Aug 27, 2020
@lukeindykiewicz lukeindykiewicz deleted the luke/reformat branch August 27, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants