Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinesis source logging wrong error message #209

Closed
TiganeteaRobert opened this issue Aug 26, 2022 · 0 comments
Closed

Kinesis source logging wrong error message #209

TiganeteaRobert opened this issue Aug 26, 2022 · 0 comments

Comments

@TiganeteaRobert
Copy link
Contributor

We should be logging kinesisPullErr here instead of err.

ks.log.WithFields(log.Fields{"error": err}).Fatal(err)
TiganeteaRobert added a commit that referenced this issue Aug 26, 2022
@TiganeteaRobert
Kinesis source logging wrong error message (closes #209)
2a32ee4
@TiganeteaRobert TiganeteaRobert mentioned this issue Aug 26, 2022
Draft
TiganeteaRobert added a commit that referenced this issue Aug 29, 2022
@TiganeteaRobert
Kinesis source logging wrong error message (closes #209)
d1aa932
colmsnowplow pushed a commit that referenced this issue Oct 21, 2022
@TiganeteaRobert @colmsnowplow
Kinesis source logging wrong error message (closes #209)
2b31d16
colmsnowplow pushed a commit that referenced this issue Oct 21, 2022
@TiganeteaRobert @colmsnowplow
Kinesis source logging wrong error message (closes #209)
8191ee8
colmsnowplow pushed a commit that referenced this issue Oct 24, 2022
@TiganeteaRobert @colmsnowplow
Kinesis source logging wrong error message (closes #209)
a18bc6a
@colmsnowplow colmsnowplow mentioned this issue Oct 24, 2022
Merged
colmsnowplow pushed a commit that referenced this issue Oct 25, 2022
@TiganeteaRobert @colmsnowplow
Kinesis source logging wrong error message (closes #209)
f91c83c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TiganeteaRobert