Fix screenView autotracking unable to send events (close #455)

snowplow · Jun 15, 2021 · 19969cc · 19969cc
1 parent 824ebee
commit 19969cc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/...racker/src/main/java/com/snowplowanalytics/snowplow/internal/tracker/ServiceProvider.java b/...racker/src/main/java/com/snowplowanalytics/snowplow/internal/tracker/ServiceProvider.java
@@ -120,6 +120,7 @@ public ServiceProvider(@NonNull Context context, @NonNull String namespace, @Non
         if (trackerConfigurationUpdate.sourceConfig == null) {
             trackerConfigurationUpdate.sourceConfig = new TrackerConfiguration(appId);
         }
+        getTracker(); // Build tracker to initialize NotificationCenter receivers
     }
 
     public void reset(@NonNull List<Configuration> configurations) {

diff --git a/snowplow-tracker/src/main/java/com/snowplowanalytics/snowplow/internal/tracker/Tracker.java b/snowplow-tracker/src/main/java/com/snowplowanalytics/snowplow/internal/tracker/Tracker.java
@@ -136,7 +136,6 @@ public static void close() {
     boolean applicationCrash;
     boolean trackerDiagnostic;
     boolean lifecycleEvents;
-    boolean screenviewEvents;
     boolean screenContext;
     boolean installTracking;
     boolean activityTracking;
@@ -154,7 +153,7 @@ public static void close() {
     private final NotificationCenter.FunctionalObserver receiveScreenViewNotification = new NotificationCenter.FunctionalObserver() {
         @Override
         public void apply(@NonNull Map<String, Object> data) {
-            if (screenviewEvents) {
+            if (activityTracking) {
                 Event event = (Event) data.get("event");
                 if (event != null) {
                     track(event);
@@ -225,7 +224,6 @@ public static class TrackerBuilder {
         boolean applicationCrash = true; // Optional
         boolean trackerDiagnostic = false; // Optional
         boolean lifecycleEvents = false; // Optional
-        boolean screenviewEvents = false; // Optional
         boolean screenContext = false; // Optional
         boolean activityTracking = false; // Optional
         boolean installTracking = false; // Optional
@@ -533,7 +531,6 @@ private Tracker(@NonNull TrackerBuilder builder) {
         this.applicationCrash = builder.applicationCrash;
         this.trackerDiagnostic = builder.trackerDiagnostic;
         this.lifecycleEvents = builder.lifecycleEvents;
-        this.screenviewEvents = builder.screenviewEvents;
         this.activityTracking = builder.activityTracking;
         this.screenState = new ScreenState();
         this.screenContext = builder.screenContext;

diff --git a/.../src/main/java/com/snowplowanalytics/snowplow/internal/tracker/TrackerControllerImpl.java b/.../src/main/java/com/snowplowanalytics/snowplow/internal/tracker/TrackerControllerImpl.java
@@ -236,14 +236,14 @@ public void setScreenContext(boolean screenContext) {
 
     @Override
     public boolean isScreenViewAutotracking() {
-        return getTracker().screenviewEvents;
+        return getTracker().activityTracking;
     }
 
     @Override
     public void setScreenViewAutotracking(boolean screenViewAutotracking) {
         getDirtyConfig().screenViewAutotracking = screenViewAutotracking;
         getDirtyConfig().screenViewAutotrackingUpdated = true;
-        getTracker().screenviewEvents = screenViewAutotracking;
+        getTracker().activityTracking = screenViewAutotracking;
     }
 
     @Override