Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.3.0 #321

Merged
merged 6 commits into from Sep 11, 2019
Merged

Release/1.3.0 #321

merged 6 commits into from Sep 11, 2019

Conversation

oguzhanunlu
Copy link
Member

@oguzhanunlu oguzhanunlu commented Jul 23, 2019 •
edited

@oguzhanunlu oguzhanunlu self-assigned this Jul 23, 2019
@oguzhanunlu oguzhanunlu added this to the 1.3.0 milestone Jul 23, 2019
@oguzhanunlu oguzhanunlu force-pushed the release/1.3.0 branch 2 times, most recently from 3afcf5c to 94fc52c Compare August 2, 2019 12:38
@coveralls
Copy link

coveralls commented Aug 2, 2019 •
edited

Coverage Status

Coverage decreased (-0.2%) to 76.611% when pulling 6043789 on release/1.3.0 into 4aec6ff on master.

@oguzhanunlu oguzhanunlu force-pushed the release/1.3.0 branch 4 times, most recently from 2f4704c to b218e60 Compare August 5, 2019 17:42
@oguzhanunlu oguzhanunlu force-pushed the release/1.3.0 branch 3 times, most recently from f946ff6 to 397f06f Compare August 14, 2019 15:12
This was referenced Aug 14, 2019
Closed
Closed
@colmsnowplow colmsnowplow self-requested a review August 20, 2019 14:00
colmsnowplow
colmsnowplow approved these changes Aug 20, 2019
View reviewed changes
Copy link

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oguzhanunlu
Copy link
Member Author

Thanks @colmsnowplow ! I've extended the PR after your review by 1 commit, could you please review that last commit too?

colmsnowplow
colmsnowplow approved these changes Aug 21, 2019
View reviewed changes
Copy link

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

jbeemster
jbeemster requested changes Aug 21, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
snowplow-demo-app/build.gradle Outdated Show resolved Hide resolved
...w-demo-app/src/androidTest/java/com/snowplowanalytics/snowplowtrackerdemo/uitest/UITest.java Show resolved Hide resolved
...w-demo-app/src/androidTest/java/com/snowplowanalytics/snowplowtrackerdemo/uitest/UITest.java Outdated Show resolved Hide resolved
snowplow-tracker/src/main/java/com/snowplowanalytics/snowplow/tracker/Tracker.java Outdated Show resolved Hide resolved
@oguzhanunlu oguzhanunlu force-pushed the release/1.3.0 branch 3 times, most recently from ca03f68 to dd5de6e Compare September 4, 2019 13:42
@oguzhanunlu
Copy link
Member Author

Hey @jbeemster , I addressed all your feedback, especially on thread.sleep usage in UI test and thread safety of gdpr context mechanisms, however the scope of the release has to be cut (configurable emitter post path and gdpr context is postponed) and I need to ask for review again on updated commits. Thanks in advance.

@lbiselli lbiselli mentioned this pull request Sep 10, 2019
Closed
@oguzhanunlu oguzhanunlu merged commit 70097dc into master Sep 11, 2019
@AlexBenny AlexBenny deleted the release/1.3.0 branch May 25, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmsnowplow colmsnowplow colmsnowplow approved these changes

@jbeemster jbeemster Awaiting requested review from jbeemster

Assignees

@oguzhanunlu oguzhanunlu

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oguzhanunlu @coveralls @jbeemster @colmsnowplow @Max2817