Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate language in platform context entity to max 8 characters (close #621) #622

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Truncate language in platform context entity to max 8 characters (close #621) #622

merged 1 commit into from
Jun 30, 2023

Conversation

matus-tomlein
Copy link
Contributor

Issue #621

This PR handles situations where the language property in the mobile_context entity was longer than 8 characters, which caused validation errors as the property has a maxLength setting of 8 chars.

mscwilson
mscwilson approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@mscwilson mscwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matus-tomlein matus-tomlein merged commit 772129a into release/5.3.0 Jun 30, 2023
3 checks passed
@matus-tomlein matus-tomlein deleted the issue/truncate_language branch June 30, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscwilson mscwilson mscwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matus-tomlein @mscwilson