Fix demo crash when using R8 full mode (close #652) #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscwilson
changed the title
matus-tomlein
approved these changes
Jan 25, 2024
| #-renamesourcefileattribute SourceFile | ||
|
|
||
| # Fixes R8 full mode crash |
There was a problem hiding this comment.
We should also add these to the setup section in the docs.
mscwilson
force-pushed
the
issue/r8_full_mode_reflection_bug
branch
from
85e3b1c
to
a395390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #652.
The crash in the Compose demo was caused by missing Retrofit classes when full R8 minification/shrinking is used. This PR adds ProGuard exemption rules for the relevant classes.
Also, dependencies for getting the appSetId and androidIdfa (AAID) platform context entity properties have been added to the Compose demo, along with ProGuard rules so that they still work with R8.