Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the emitter generic (Closes #162) #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szareiangm
Copy link
Contributor

@szareiangm szareiangm commented Jul 6, 2020

This is my first step towards improving elasticsearch loader. In this PR, I made the Emitter to receive genertic class type. My next step is to add filters (#165)

PS: Good sink can be handled separately from the emitter, mostly it is just Stdout. Also, There is a failing unit-test. I am checking why.

CC: @dmatth

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@szareiangm
Copy link
Contributor Author

I signed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants