Fix tracker initialization with partial platform context property overrides on Android #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrides on Android
matus-tomlein
requested review from
mscwilson and
adatzer
and removed request for
adatzer
mscwilson
approved these changes
Apr 9, 2024
matus-tomlein
deleted the
issue/fix_incomplete_platform_context_property_overrides
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the tracker was initialized with only some properties overriden in
TrackerConfiguration.platformContextProperties, the tracker initialization on Android failed and the tracker was not initialized.The problem was due to wrong serialization of the config. This PR fixes the bug and adds a test.