Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emitter configuration support to remote configuration #782

Closed
matus-tomlein opened this issue May 25, 2023 · 1 comment
Closed

Add emitter configuration support to remote configuration #782

matus-tomlein opened this issue May 25, 2023 · 1 comment
Assignees
@matus-tomlein
Labels
type:enhancement New features or improvements to existing features.
Milestone
5.3.0

Comments

@matus-tomlein
Copy link
Contributor

Enable configuring relevant parts of the emitter configuration using remote configuration. The properties of interest would be:

  • bufferOption
  • emitRange
  • threadPoolSize
  • byteLimitGet
  • byteLimitPost
  • customRetryForStatusCodes
  • serverAnonymisation

These are already available in the 1-0-1 schema for the remote_config.
@matus-tomlein matus-tomlein mentioned this issue May 25, 2023
Closed
@JasminFrei
Copy link

Thanks for creating this issue. Don't forget to also make these options available in the default configuration that can be used to set up the tracker before the remote config was loaded.

@matus-tomlein matus-tomlein added this to the 5.3.0 milestone Jun 2, 2023
@matus-tomlein matus-tomlein self-assigned this Jun 14, 2023
@matus-tomlein matus-tomlein added the type:enhancement New features or improvements to existing features. label Jun 14, 2023
matus-tomlein added a commit that referenced this issue Jun 14, 2023
@matus-tomlein
Add emitter configuration support to remote configuration (close #782)
7298008
@matus-tomlein matus-tomlein mentioned this issue Jun 14, 2023
Merged
matus-tomlein added a commit that referenced this issue Jun 21, 2023
@matus-tomlein
Add emitter configuration support to remote configuration (close #782)
aa77473 
PR #792
matus-tomlein added a commit that referenced this issue Jun 21, 2023
@matus-tomlein
Revert "Add emitter configuration support to remote configuration (close
48cd5cf 
 #782)"

This reverts commit aa77473.
matus-tomlein added a commit that referenced this issue Jun 29, 2023
@matus-tomlein
Add emitter configuration support to remote configuration (close #782)
47289e9
@matus-tomlein matus-tomlein mentioned this issue Jun 30, 2023
Merged
greg-el pushed a commit that referenced this issue Sep 28, 2023
@matus-tomlein @greg-el
Add emitter configuration support to remote configuration (close #782)
e120ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matus-tomlein matus-tomlein

Labels
type:enhancement New features or improvements to existing features.
Projects
None yet
Milestone
5.3.0
Development

No branches or pull requests
2 participants
@matus-tomlein @JasminFrei