Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no way to remove all the events from the database #834

Closed
danigutierrezayuso opened this issue Oct 4, 2023 · 1 comment
Closed

There is no way to remove all the events from the database #834

danigutierrezayuso opened this issue Oct 4, 2023 · 1 comment
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
6.0.0

Comments

@danigutierrezayuso
Copy link
Contributor

Describe the bug

Although the eventStore used by default has a removeAllEvents function, it can't be called from outside the sdk.

In some cases it can be useful to access that eventStore and use the removeAllEvents function publicly.

To Reproduce

tracker?.emitter?.eventStore?.removeAllEvents() doesn't compile

Expected behavior
tracker?.emitter?.eventStore?.removeAllEvents() compiles and allows the deletion of all the events saved in the database
@danigutierrezayuso danigutierrezayuso added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Oct 4, 2023
@danigutierrezayuso
Copy link
Contributor Author

I've opened a PR adding this change (without adding any new tests): #835

@matus-tomlein matus-tomlein mentioned this issue Jan 30, 2024
Merged
matus-tomlein added a commit that referenced this issue Jan 31, 2024
@matus-tomlein @danigutierrezayuso
Expose event store from emitter controller to be able to remove all e…
2702397 
…vents from database (close #834)

PR #870

---------

Co-authored-by: Daniel Gutiérrez Ayuso <danielgay@inditex.com>
@matus-tomlein matus-tomlein added this to the 6.0.0 milestone Feb 1, 2024
@matus-tomlein matus-tomlein mentioned this issue Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@matus-tomlein @danigutierrezayuso