Unnecessary optionality of TrackerController #847
Labels
type:enhancement
New features or improvements to existing features.
Milestone
Comments
Kymer
added
the
type:enhancement
Kymer
added a commit
to Kymer/snowplow-ios-tracker
that referenced
this issue
Nov 30, 2023
Kymer
added a commit
to Kymer/snowplow-ios-tracker
that referenced
this issue
Nov 30, 2023
Kymer
added a commit
to Kymer/snowplow-ios-tracker
that referenced
this issue
Nov 30, 2023
Kymer
added a commit
to Kymer/snowplow-ios-tracker
that referenced
this issue
Nov 30, 2023
Kymer
added a commit
to Kymer/snowplow-ios-tracker
that referenced
this issue
Nov 30, 2023
Kymer
added a commit
to Kymer/snowplow-ios-tracker
that referenced
this issue
Nov 30, 2023
matus-tomlein
pushed a commit
that referenced
this issue
Dec 1, 2023
matus-tomlein
pushed a commit
that referenced
this issue
Dec 1, 2023
matus-tomlein
pushed a commit
that referenced
this issue
Dec 7, 2023
matus-tomlein
pushed a commit
that referenced
this issue
Dec 7, 2023
matus-tomlein
pushed a commit
that referenced
this issue
Jan 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since the major version bump from Snowplow 4.x to 5.x (the move to Swift) calling
Snowplow.createTracker(namespace:network:configurations:)now returns an optionalTrackerController. Upon closer inspection, this optional is not needed. With minimal effort and only a few internal changes I was able get rid of the optionality.Perhaps this was a small oversight with the move to Swift. If not: what is the reasoning behind that function call to return an optional tracker? If it's not deemed necessary I'd be willing to open a PR to address this 🙂
The text was updated successfully, but these errors were encountered: