Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default buffer option to single #849

Closed
matus-tomlein opened this issue Nov 30, 2023 · 1 comment
Closed

Change default buffer option to single #849

matus-tomlein opened this issue Nov 30, 2023 · 1 comment
Assignees
@matus-tomlein
Milestone
6.0.0

Comments

@matus-tomlein
Copy link
Contributor

Even though we state the default buffer option in the tracker is 10, in practice the buffer option is 1 (due to issue #827). This means that events are sent right when they are tracked.

This is also the configuration on the JavaScript tracker (buffer size 1) and is a good default to use in client side apps to prevent some events hanging in the event store when the app is quit/uninstalled earlier than the event store is cleared.

After fixing issue #827, in order to keep this behaviour, we will need to change the default buffer size to 1.
@matus-tomlein matus-tomlein self-assigned this Nov 30, 2023
@matus-tomlein matus-tomlein added this to the 6.0.0 milestone Nov 30, 2023
matus-tomlein added a commit that referenced this issue Nov 30, 2023
@matus-tomlein
Change default buffer option to single (#849)
7cb7e54
@matus-tomlein matus-tomlein mentioned this issue Dec 1, 2023
Merged
matus-tomlein added a commit that referenced this issue Dec 1, 2023
@matus-tomlein
Change default buffer option to single (#849)
23233eb
matus-tomlein added a commit that referenced this issue Dec 7, 2023
@matus-tomlein
Change default buffer option to single (#849)
33e47fd
matus-tomlein added a commit that referenced this issue Dec 8, 2023
@matus-tomlein
Change default buffer option to single (#849)
2123ba9
matus-tomlein added a commit that referenced this issue Jan 19, 2024
@matus-tomlein
Change default buffer option to single (#849)
0ed998c
matus-tomlein added a commit that referenced this issue Jan 19, 2024
@matus-tomlein
Change default buffer option to single (#849)
cd7906a
@matus-tomlein matus-tomlein mentioned this issue Feb 1, 2024
Merged
@matus-tomlein
Copy link
Contributor Author

Released in version 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matus-tomlein matus-tomlein

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@matus-tomlein