Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded okhttp dependency has breaking change. #365

Closed
fathimaSheikh opened this issue Oct 9, 2023 · 1 comment
Closed

Upgraded okhttp dependency has breaking change. #365

fathimaSheikh opened this issue Oct 9, 2023 · 1 comment
Assignees
Labels
status:completed Completed - but might not be released yet.

Comments

@fathimaSheikh
Copy link

fathimaSheikh commented Oct 9, 2023

Describe the bug
With 4.10 version of okhttp, there's a breaking change with use of function RequestBody.create(payload, JSON). It's changed to RequestBody.create(JSON, payload)

** Expect**
Would be great to have the dependency updated and fix complier issue.

** Version **
Works with version 4.9.3
Compiler errors with version 4.10

Screenshot 2023-10-09 at 5 02 10 PM complete the following information):**
@fathimaSheikh fathimaSheikh changed the title OkHttpClientAdapter references incorrect doPost method Upgraded okhttp dependency has breaking change. Oct 9, 2023
@matus-tomlein matus-tomlein self-assigned this Jan 10, 2024
@matus-tomlein
Copy link
Contributor

Hi @fathimaSheikh, thank you for the report!

We will definitely update the okhttp dependency to the latest version (4.12), but I am confused about the problem because according to the okhttp code the correct order of the arguments in RequestBody.create() is to put the content first and then the content type, see here. The other order (content type first) that you suggest is deprecated.

@github-actions github-actions bot added the status:in_progress Maintainers are working on this. label Jan 10, 2024
@github-actions github-actions bot added status:completed Completed - but might not be released yet. and removed status:in_progress Maintainers are working on this. labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:completed Completed - but might not be released yet.
Projects
None yet
Development

No branches or pull requests

2 participants