Skip to content

Commit

Permalink
Add podSize property to ad break and update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
matus-tomlein committed May 18, 2023
1 parent 90ca97d commit 60e11ee
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions plugins/browser-plugin-media/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export enum MediaType {

/** Type/Schema for a context entity for media player events with information about the current state of the media player */
export interface MediaPlayer extends Record<string, unknown> {
/** The current playback time */
/** The current playback time position within the media in seconds */
currentTime: number;
/** A double-precision floating-point value indicating the duration of the media in seconds */
duration?: number | null;
Expand Down Expand Up @@ -226,7 +226,7 @@ export interface MediaPlayer extends Record<string, unknown> {

/** Partial type/schema for a context entity for media player events with information about the current state of the media player */
export interface MediaPlayerUpdate {
/** The current playback time */
/** The current playback time position within the media in seconds */
currentTime?: number;
/** A double-precision floating-point value indicating the duration of the media in seconds */
duration?: number | null;
Expand Down Expand Up @@ -351,6 +351,8 @@ export interface MediaAdBreak extends Record<string, unknown> {
* - companion (accompany the video but placed outside the player)
*/
breakType?: MediaAdBreakType;
/** The number of ads to be played within the ad break */
podSize?: number;
}

/** Partial type/schema for a context entity, shared with all media_player_ad events belonging to the ad break */
Expand All @@ -368,6 +370,8 @@ export interface MediaPlayerAdBreakUpdate {
* - companion (accompany the video but placed outside the player)
*/
breakType?: MediaAdBreakType;
/** The number of ads to be played within the ad break */
podSize?: number;
}

export interface CommonMediaEventProperties extends CommonEventProperties {
Expand Down

0 comments on commit 60e11ee

Please sign in to comment.