Skip to content

Commit

Permalink
Rename event schemas for playback_rate_change and picture_in_picture_…
Browse files Browse the repository at this point in the history
…change events
  • Loading branch information
matus-tomlein committed Apr 25, 2023
1 parent 90633b1 commit 861e96e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions plugins/browser-plugin-media/src/schemata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ function eventNameForEventType(eventType: MediaPlayerEventType): string {
return 'media_player_event_seek_end';

case MediaPlayerEventType.PlaybackRateChange:
return 'media_player_event_playbackrate_change';
return 'media_player_event_playback_rate_change';
case MediaPlayerEventType.VolumeChange:
return 'media_player_event_volume_change';
case MediaPlayerEventType.FullscreenChange:
return 'media_player_event_fullscreen_change';
case MediaPlayerEventType.PictureInPictureChange:
return 'media_player_event_pictureinpicture_change';
return 'media_player_event_picture_in_picture_change';

case MediaPlayerEventType.Ping:
return 'media_player_event_ping';
Expand Down
4 changes: 2 additions & 2 deletions plugins/browser-plugin-media/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ export enum MediaPlayerEventType {
// Changes in playback settings

/** Media player event sent when the playback rate has changed. */
PlaybackRateChange = 'playbackrate_change',
PlaybackRateChange = 'playback_rate_change',
/** Media player event sent when the volume has changed. */
VolumeChange = 'volume_change',
/** Media player event fired immediately after the browser switches into or out of full-screen mode. */
FullscreenChange = 'fullscreen_change',
/** Media player event fired immediately after the browser switches into or out of picture-in-picture mode. */
PictureInPictureChange = 'pictureinpicture_change',
PictureInPictureChange = 'picture_in_picture_change',

// Tracking playback progress

Expand Down

0 comments on commit 861e96e

Please sign in to comment.