Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make domainUserId a UUID #274

Closed
fblundun opened this issue Oct 21, 2014 · 8 comments
Closed

Make domainUserId a UUID #274

fblundun opened this issue Oct 21, 2014 · 8 comments
Assignees
Labels
category:browser About the browser-specific code. type:enhancement New features or improvements to existing features.
Milestone

Comments

@fblundun
Copy link
Contributor

No description provided.

@fblundun fblundun added type:enhancement New features or improvements to existing features. category:browser About the browser-specific code. labels Oct 21, 2014
@fblundun fblundun self-assigned this Oct 21, 2014
@fblundun fblundun added this to the Version 2.2.0 milestone Oct 21, 2014
@alexanderdean
Copy link
Member

@alexanderdean
Copy link
Member

@fblundun
Copy link
Contributor Author

If we don't want to break the pipeline for people who haven't upgraded to the latest table definition (with the increased domain_userid field size), we could do this in two steps: to start with we could generate a proper uuid and drop all but 16 characters of it. I think this would still be higher entropy than the current implementation (a hash of browser features and the timestamp to the nearest second), but would have to check the uuid generation method to be sure.

@alexanderdean
Copy link
Member

That will be the de facto behaviour anyway I think if someone hasn't upgraded their Redshift - the domain_userid value will get truncated at 16 characters.

I think when we release this in the 3.0.0 we should push people to upgrade their Redshift at the same time, so there is only one breakage in user IDs (old to UUID), rather than two breakages (old to truncated UUID to full UUID)...

@fblundun
Copy link
Contributor Author

We don't necessarily need a breakage at all - we could just keep the old user IDs when they are available in the ID cookie and generate a new UUID otherwise.

@alexanderdean
Copy link
Member

Ah - I like it!

@alexanderdean
Copy link
Member

Bringing forwards following Augur analysis

@alexanderdean
Copy link
Member

Bringing forwards as we should get on with this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:browser About the browser-specific code. type:enhancement New features or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

3 participants