Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable max GET request size in bytes attribute #449

Closed
fblundun opened this issue Jan 29, 2016 · 2 comments
Closed

Add configurable max GET request size in bytes attribute #449

fblundun opened this issue Jan 29, 2016 · 2 comments
Assignees
Labels
category:browser About the browser-specific code. priority:low Not on the roadmap. status:needs_triage Needs maintainer triage. type:enhancement New features or improvements to existing features.
Milestone

Comments

@fblundun
Copy link
Contributor

Unfortunately it isn't possible to tell from JavaScript whether the GET response had status code 414 (source). We could instead have a configurable maximum GET size to match the configurable maximum POST size.

Or maybe we should just tell people who are trying to send large events to use POST instead.

@fblundun fblundun added type:enhancement New features or improvements to existing features. category:browser About the browser-specific code. labels Jan 29, 2016
@fblundun fblundun added this to the Version 2.7.0 milestone Jan 29, 2016
@fblundun fblundun self-assigned this Jan 29, 2016
@sprsam
Copy link

sprsam commented Sep 16, 2019

Has there been any further examination of this? Attempting to implement some kind of error handling when a payload (normally well under the GET limit) inadvertently includes too much/bad data.
Since we aren't able to receive the response status, we can't react to a bad event by removing it from localStorage. Playing around error event listeners didn't seem to help intercept/receive, unfortunately. Is there a suggested alternative? Currently considering checking the approximate size of a payload before making the call to sendEvent, but it seems like there should be a way to react to an error response from Snowplow.

@paulboocock paulboocock removed this from the Version 2.11.0 milestone Dec 10, 2019
@paulboocock
Copy link
Contributor

We haven't investigated this much further, our current advice would be to switch the eventMethod to 'post' or 'beacon'.

@paulboocock paulboocock added priority:low Not on the roadmap. status:needs_triage Needs maintainer triage. labels Feb 7, 2020
@matus-tomlein matus-tomlein changed the title Don't try to send overly long GET requests more than once Add configurable max GET request size in bytes attribute Mar 8, 2022
@matus-tomlein matus-tomlein self-assigned this Mar 8, 2022
@matus-tomlein matus-tomlein added this to the Version 3.4.0 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:browser About the browser-specific code. priority:low Not on the roadmap. status:needs_triage Needs maintainer triage. type:enhancement New features or improvements to existing features.
Projects
None yet
Development

No branches or pull requests

4 participants