Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/3.9.0 #1169

Merged
merged 13 commits into from Mar 30, 2023
Merged

Release/3.9.0 #1169

merged 13 commits into from Mar 30, 2023

Conversation

igneel64
Copy link
Contributor

Release 3.9.0 containing:

Enhancements:

  • Fixes for flaky end-to-end tests
  • Add implicit total_quantity calculation on snowplow ecommerce transactions

matus-tomlein and others added 13 commits February 8, 2023 14:21
@matus-tomlein @igneel64
Add client_session context entity if anonymous tracking with session …
a2eb8aa 
…tracking is enabled (close #1124)

PR #1135
@igneel64
Add files attribute for npm publishing in JavaScript tracker
8be01bb 
close #1146
@igneel64
Add NPM descriptions for snowplow-ecommerce and enhanced-consent
792e895 
close #1148
@igneel64
Remove fixed values for playbackQuality in YT integrations plus type …
742831c 
…fixes

closes #1122
@igneel64
Add touchend and touchstart events on page ping calculation (close #479)
cbc403c 
#1160
@matus-tomlein
Fix flaky end-to-end tests
d971b17 
PR #1152
@igneel64
Fix root domain algorithm initial attempt (close #1162)
f4b5481 
#1163
@greg-el
Accept YT.Player instance in enableYouTubeTracking (close #1141)
5951366 
PR: #1155

We currently only accept a string id for an Iframe to signify which
element to track, and attach our listeners on the `onReady` callback
provided by the player.

This doesn't work with Iframes that already have players, as the
`onReady` callback is never fired. To mitigate this we can accept an
instance of `YT.Player` in our `id` field.
@matus-tomlein
Fix generating domain user ID when clearing user data with anonymous …
a83647b 
…tracking (close #1164)

PR #1165
@igneel64
Add implicit total_quantity calculation on snowplow ecommerce transac…
c560c01 
…tion tracking

#1168
@igneel64
Add tab identifier and browser context (close #1142) (close #815)
a769824 
#1088
@matus-tomlein
Make sure brands array in client hints plugin is serialized as an arr…
0a36a02 
…ay in context entity (close #1082)

PR #1143
@igneel64
Add snowplow ecommerce promotion actions (close #1157)
fa6f1cc 
#1158
@bundlemon
Copy link

bundlemon bot commented Mar 29, 2023 •
edited

BundleMon

Files added (6)
Status Path Size Limits
✅ libraries/browser-tracker-core/dist/index.mod
ule.js
 +24.52KB 25KB / +10%
✅ trackers/javascript-tracker/dist/sp.js
 +23.84KB 25KB / +10%
✅ trackers/javascript-tracker/dist/sp.lite.js
 +14.53KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.umd.min.j
s
 +14.4KB 15KB / +10%
✅ libraries/tracker-core/dist/index.module.js
 +13.35KB 15KB / +10%
✅ trackers/browser-tracker/dist/index.module.js
 +3.46KB 5KB / +10%

Total files change +94.09KB 0%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

matus-tomlein
matus-tomlein reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the nextBump property in version-policies.json is set to prerelease. Make sure to update to minor in a prepare for release commit.

@igneel64
Copy link
Contributor Author

@matus-tomlein
It should probably be release to move out of beta, is that right ?

@matus-tomlein
Copy link
Contributor

@igneel64 oh right, I think that's true.

@igneel64
Copy link
Contributor Author

@matus-tomlein
Testing this with rush version --bump , release is not valid 😂 minor seems to do the trick

matus-tomlein
matus-tomlein approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🚢

greg-el
greg-el approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@greg-el greg-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds and runs fine! 🎉

@igneel64 igneel64 merged commit 76d7387 into master Mar 30, 2023
3 of 4 checks passed
@igneel64 igneel64 deleted the release/3.9.0 branch March 30, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matus-tomlein matus-tomlein matus-tomlein approved these changes

@greg-el greg-el greg-el approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igneel64 @matus-tomlein @greg-el