Create performance navigation timing plugin (close #1171) #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles added (6)
Total files change +94.09KB 0% Final result: ✅ View report in BundleMon website ➡️ |
plugins/browser-plugin-performance-navigation-timing/src/contexts.ts
Outdated
Show resolved
Hide resolved
plugins/browser-plugin-performance-navigation-timing/src/index.ts
Outdated
Show resolved
Hide resolved
jethron
reviewed
Apr 18, 2023
plugins/browser-plugin-performance-navigation-timing/src/contexts.ts
Outdated
Show resolved
Hide resolved
plugins/browser-plugin-performance-navigation-timing/src/contexts.ts
Outdated
Show resolved
Hide resolved
igneel64
force-pushed
the
feature/1171-add-performance-navigation-timing-plugin
branch
from
6214b35
to
7d6a8f8
Compare
jethron
approved these changes
Apr 20, 2023
| ## Maintainer quick start | ||
|
|
||
| Part of the Snowplow JavaScript Tracker monorepo. | ||
| Build with [Node.js](https://nodejs.org/en/) (14 or 16) and [Rush](https://rushjs.io/). |
There was a problem hiding this comment.
Sidenote: Node 14 hits EOL in like 10 days, do we have plans to support current LTS (18) for all our stuff in the near future?
There was a problem hiding this comment.
For our build systems, we should make sure Rush supports Node.js 18 properly, but from my experience we can just test it out and change our docs as required.
For the targets, in v4 we ditched Node.js 12 but we will be keeping Node.js 14 as the minimum still. On that, we need to make sure we also support Node.js 18 and Node.js 20 on our Node.js tracker.
igneel64
force-pushed
the
feature/1171-add-performance-navigation-timing-plugin
branch
2 times, most recently
from
2b2187c
to
c9860b8
Compare
igneel64
force-pushed
the
feature/1171-add-performance-navigation-timing-plugin
branch
from
c9860b8
to
98f0eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
@snowplow/browser-plugin-performance-navigation-timingplugin which will pull information from PerformanceNavigationTiming API.Currently this works like the
performance-timingplugin, attaching the context in each event after activation.