Fix newTracker typing to accurately return null or undefined (fix #1167) #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles added (6)
Total files change +95.17KB 0% Final result: ✅ View report in BundleMon website ➡️ |
matus-tomlein
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Looks good! I'm just wondering whether we can release this in v3 or should wait for v4. I know that it doesn't change the behaviour of the tracker, but the change in the type can cause some user code to produce typescript errors with handling the null or undefined that might have not been produced before. I think this could be considered a breaking as users would need to change how they use the result of newTracker(). So my opinion is that we should release this in v4.
|
@matus-tomlein |
igneel64
force-pushed
the
fix/1167-correct-newTracker-function-on-browser-tracker
branch
from
20ed72b
to
7f7b010
Compare
igneel64
force-pushed
the
release/4.0.0
branch
from
70bbdcc
to
444c184
Compare
igneel64
force-pushed
the
fix/1167-correct-newTracker-function-on-browser-tracker
branch
from
7f7b010
to
b210872
Compare
igneel64
force-pushed
the
release/4.0.0
branch
from
444c184
to
51dc112
Compare
igneel64
force-pushed
the
fix/1167-correct-newTracker-function-on-browser-tracker
branch
from
b210872
to
61e1d46
Compare
igneel64
deleted the
fix/1167-correct-newTracker-function-on-browser-tracker
branch
igneel64
added a commit
that referenced
this pull request
Sep 13, 2023
matus-tomlein
pushed a commit
that referenced
this pull request
Jul 8, 2024
matus-tomlein
pushed a commit
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix correct typing issue for
newTrackerpossibly returning:nullwhen a tracker is already initialized with the same tracker id.undefinedwhen we are not in a browser context.(close #1167)