Add PrivacySandboxPlugin (close #1205) #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles added (6)
Total files change +95.6KB 0% Final result: ✅ View report in BundleMon website ➡️ |
jethron
reviewed
Jul 18, 2023
plugins/browser-plugin-privacy-sandbox/test/privacy-sandbox.test.ts
Outdated
Show resolved
Hide resolved
igneel64
force-pushed
the
feature/1205-add-privacy-sandbox-plugin
branch
2 times, most recently
from
96e1531
to
fc82773
Compare
matus-tomlein
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
LGTM, nice plugin!
Since the topics API is still in the state of a proposal, it's probably worth setting the expectations for this in the docs with some disclaimer. Just so that users don't expect to see lots of data coming in while the API is not yet fully launched.
| "typescript": "~4.6.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "@snowplow/browser-tracker": "~3.12.0" |
There was a problem hiding this comment.
Just a reminder to update the version here and at the top of the file before merging.
igneel64
force-pushed
the
feature/1205-add-privacy-sandbox-plugin
branch
2 times, most recently
from
b14195d
to
9d83278
Compare
matus-tomlein
force-pushed
the
release/3.14.0
branch
from
ed9bbba
to
0b3950a
Compare
igneel64
force-pushed
the
feature/1205-add-privacy-sandbox-plugin
branch
from
9d83278
to
c4818ae
Compare
greg-el
pushed a commit
that referenced
this pull request
Aug 10, 2023
greg-el
pushed a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the
PrivacySandboxPluginThis plugin aims to progressively include Privacy Sandbox API data collection which can prove useful for analysis.
The first step to that is the Topics API. You can read more about it in the currect specification.
Schema
Proposed schema snowplow/iglu-central#1319