Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.8.0 #351

Merged
merged 15 commits into from Apr 29, 2018
Merged

Release/0.8.0 #351

merged 15 commits into from Apr 29, 2018

Conversation

mhadam
Copy link
Contributor

@mhadam mhadam commented Apr 2, 2018

Missing open notification commit - will be added shortly.

@coveralls
Copy link

coveralls commented Apr 3, 2018

Coverage Status

Coverage decreased (-0.8%) to 64.709% when pulling 9f1d3e0 on release/0.8.0 into 2ae91e4 on master.

@alexanderdean alexanderdean added this to the Version 0.8.0 milestone Apr 3, 2018
@alexanderdean
Copy link
Member

Looking good - please add a "Prepare for release" commit which updates CHANGELOG, README etc (see previous releases for examples)

@mhadam mhadam force-pushed the release/0.8.0 branch 2 times, most recently from 71dfbcd to 3d5e87a Compare April 5, 2018 14:25
@alexanderdean
Copy link
Member

Hey @mhadam - I am getting some problems here when I am trying to prepare for release (per #337):

I am running:

$ pod lib lint --allow-warnings

And getting:

 -> SnowplowTracker (0.8.0)
    - ERROR | xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - WARN  | [OSX] xcodebuild:  FMDB/src/fmdb/FMDatabaseQueue.m:83:9: warning: 'dispatch_queue_set_specific' is only available on macOS 10.7 or newer [-Wunguarded-availability]
    - NOTE  | [OSX] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/dispatch/queue.h:1216:1: note: 'dispatch_queue_set_specific' has been explicitly marked partial here
    - NOTE  | [OSX] xcodebuild:  FMDB/src/fmdb/FMDatabaseQueue.m:83:9: note: enclose 'dispatch_queue_set_specific' in an @available check to silence this warning
    - WARN  | [OSX] xcodebuild:  FMDB/src/fmdb/FMDatabaseQueue.m:152:54: warning: 'dispatch_get_specific' is only available on macOS 10.7 or newer [-Wunguarded-availability]
    - NOTE  | [OSX] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/dispatch/queue.h:1272:1: note: 'dispatch_get_specific' has been explicitly marked partial here
    - NOTE  | [OSX] xcodebuild:  FMDB/src/fmdb/FMDatabaseQueue.m:152:54: note: enclose 'dispatch_get_specific' in an @available check to silence this warning
    - WARN  | [OSX] xcodebuild:  FMDB/src/fmdb/FMDatabase.m:245:49: warning: 'arc4random_uniform' is only available on macOS 10.7 or newer [-Wunguarded-availability]
    - NOTE  | [OSX] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/stdlib.h:279:3: note: 'arc4random_uniform' has been explicitly marked partial here
    - NOTE  | [OSX] xcodebuild:  FMDB/src/fmdb/FMDatabase.m:245:49: note: enclose 'arc4random_uniform' in an @available check to silence this warning
    - NOTE  | xcodebuild:  /Users/alex/Development/snowplow/snowplow-objc-tracker/Snowplow/SPUtilities.h:24:9: fatal error: 'UserNotifications/UserNotifications.h' file not found
    - ERROR | xcodebuild:  /Users/alex/Development/snowplow/snowplow-objc-tracker/Snowplow/SPUtilities.h:197:59: error: 'UNNotificationAttachment' is unavailable: not available on tvOS
    - NOTE  | xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator11.3.sdk/System/Library/Frameworks/UserNotifications.framework/Headers/UNNotificationAttachment.h:13:12: note: 'UNNotificationAttachment' has been explicitly marked unavailable here
    - WARN  | [tvOS] xcodebuild:  /Users/alex/Development/snowplow/snowplow-objc-tracker/Snowplow/SPEmitter.m:320:26: warning: 'sendSynchronousRequest:returningResponse:error:' is deprecated: first deprecated in tvOS 9.0 - Use [NSURLSession dataTaskWithRequest:completionHandler:] (see NSURLSession.h [-Wdeprecated-declarations]
    - NOTE  | [tvOS] xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator11.3.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLConnection.h:401:1: note: 'sendSynchronousRequest:returningResponse:error:' has been explicitly marked deprecated here

[!] SnowplowTracker did not pass validation, due to 2 errors.
You can use the `--no-clean` option to inspect any issue.

@mhadam
Copy link
Contributor Author

mhadam commented Apr 28, 2018

@alexanderdean forgot to mention the lint errors should be gone now

@alexanderdean
Copy link
Member

Legend! Thanks @mhadam, will give it a spin...

@alexanderdean alexanderdean merged commit b4f78fb into master Apr 29, 2018
@mhadam mhadam deleted the release/0.8.0 branch February 21, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants