Skip to content

Commit

Permalink
Fix tstamp parameter in track_self_describing_event (close #350)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jack-Keene committed Jul 12, 2023
1 parent f722a96 commit d236424
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
28 changes: 14 additions & 14 deletions snowplow_tracker/test/unit/test_tracker.py
Expand Up @@ -771,7 +771,7 @@ def test_track_link_click(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_link_click_optional_none(self, mok_track_unstruct: Any) -> None:
Expand All @@ -795,7 +795,7 @@ def test_track_link_click_optional_none(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertTrue(callArgs["context"] is None)
self.assertTrue(callArgs["true_timestamp"] is None)
self.assertTrue(callArgs["tstamp"] is None)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_add_to_cart(self, mok_track_unstruct: Any) -> None:
Expand Down Expand Up @@ -835,7 +835,7 @@ def test_track_add_to_cart(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_add_to_cart_optional_none(self, mok_track_unstruct: Any) -> None:
Expand All @@ -857,7 +857,7 @@ def test_track_add_to_cart_optional_none(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertTrue(callArgs["context"] is None)
self.assertTrue(callArgs["true_timestamp"] is None)
self.assertTrue(callArgs["tstamp"] is None)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_remove_from_cart(self, mok_track_unstruct: Any) -> None:
Expand Down Expand Up @@ -897,7 +897,7 @@ def test_track_remove_from_cart(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_remove_from_cart_optional_none(
Expand All @@ -921,7 +921,7 @@ def test_track_remove_from_cart_optional_none(
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertTrue(callArgs["context"] is None)
self.assertTrue(callArgs["true_timestamp"] is None)
self.assertTrue(callArgs["tstamp"] is None)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_form_change(self, mok_track_unstruct: Any) -> None:
Expand Down Expand Up @@ -961,7 +961,7 @@ def test_track_form_change(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_form_change_optional_none(self, mok_track_unstruct: Any) -> None:
Expand All @@ -987,7 +987,7 @@ def test_track_form_change_optional_none(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertTrue(callArgs["context"] is None)
self.assertTrue(callArgs["true_timestamp"] is None)
self.assertTrue(callArgs["tstamp"] is None)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_form_submit(self, mok_track_unstruct: Any) -> None:
Expand Down Expand Up @@ -1029,7 +1029,7 @@ def test_track_form_submit(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_form_submit_invalid_element_type(
Expand Down Expand Up @@ -1104,7 +1104,7 @@ def test_track_form_submit_invalid_element_type_disabled_contracts(
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_form_submit_optional_none(self, mok_track_unstruct: Any) -> None:
Expand All @@ -1122,7 +1122,7 @@ def test_track_form_submit_optional_none(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertTrue(callArgs["context"] is None)
self.assertTrue(callArgs["true_timestamp"] is None)
self.assertTrue(callArgs["tstamp"] is None)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_form_submit_empty_elems(self, mok_track_unstruct: Any) -> None:
Expand Down Expand Up @@ -1170,7 +1170,7 @@ def test_track_site_search(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)

@mock.patch("snowplow_tracker.Tracker.track_self_describing_event")
def test_track_site_search_optional_none(self, mok_track_unstruct: Any) -> None:
Expand All @@ -1191,7 +1191,7 @@ def test_track_site_search_optional_none(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertTrue(callArgs["context"] is None)
self.assertTrue(callArgs["true_timestamp"] is None)
self.assertTrue(callArgs["tstamp"] is None)

@mock.patch("snowplow_tracker.Tracker.track")
def test_track_mobile_screen_view(self, mok_track: Any) -> None:
Expand Down Expand Up @@ -1246,4 +1246,4 @@ def test_track_screen_view(self, mok_track_unstruct: Any) -> None:
self.assertEqual(len(callArgs), 4)
self.assertDictEqual(callArgs["event_json"].to_json(), expected)
self.assertIs(callArgs["context"][0], ctx)
self.assertEqual(callArgs["true_timestamp"], evTstamp)
self.assertEqual(callArgs["tstamp"], evTstamp)
16 changes: 8 additions & 8 deletions snowplow_tracker/tracker.py
Expand Up @@ -316,7 +316,7 @@ def track_link_click(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down Expand Up @@ -380,7 +380,7 @@ def track_add_to_cart(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down Expand Up @@ -444,7 +444,7 @@ def track_remove_from_cart(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down Expand Up @@ -510,7 +510,7 @@ def track_form_change(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down Expand Up @@ -563,7 +563,7 @@ def track_form_submit(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down Expand Up @@ -618,7 +618,7 @@ def track_site_search(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down Expand Up @@ -807,7 +807,7 @@ def track_screen_view(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down Expand Up @@ -992,7 +992,7 @@ def track_unstruct_event(
self.track_self_describing_event(
event_json=event_json,
context=context,
true_timestamp=tstamp,
tstamp=tstamp,
event_subject=event_subject,
)
return self
Expand Down

0 comments on commit d236424

Please sign in to comment.