Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Docker base image from CentOS (as it is now EOL) (close #283) #284

Merged
merged 2 commits into from Oct 26, 2022

Conversation

cpnat
Copy link
Contributor

@cpnat cpnat commented Oct 25, 2022

As CentOS is now EOL, this change switches the Docker base image (used for development and CI) to debian:bullseye-slim

Debian is actively maintained and receives feature and security updates.

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@snowplowcla snowplowcla added the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label Oct 25, 2022
@cpnat
Copy link
Contributor Author

cpnat commented Oct 25, 2022

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

CLA signed

@paulboocock paulboocock added cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. and removed cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. labels Oct 25, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.007% when pulling 43a84d9 on cpnat:issue/283 into 4e3a4b8 on snowplow:master.

@Jack-Keene Jack-Keene changed the base branch from master to release/0.12.0 October 26, 2022 11:00
Copy link
Contributor

@Jack-Keene Jack-Keene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cpnat, thanks for your contribution to the Snowplow Python tracker. I have approved this PR and it will be released in the 0.12 version.

@Jack-Keene Jack-Keene changed the title Switch Docker base image to Debian (closes #283) Switch Docker base image from CentOS (as it is now EOL) (close #283) Oct 26, 2022
@Jack-Keene Jack-Keene merged commit 63505a4 into snowplow:release/0.12.0 Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants