RDB Loader: integrate Sentry (close #235)

snowplow · Dec 10, 2020 · 8b0ce82 · 8b0ce82
1 parent 89c57ba
commit 8b0ce82
Show file tree

Hide file tree

Showing 10 changed files with 211 additions and 123 deletions.
diff --git a/build.sbt b/build.sbt
@@ -69,6 +69,7 @@ lazy val loader = project.in(file("modules/loader"))
       Dependencies.ssm,
       Dependencies.dynamodb,
       Dependencies.jSch,
+      Dependencies.sentry,
 
       Dependencies.specs2,
       Dependencies.specs2ScalaCheck,

diff --git a/...common/src/main/scala/com/snowplowanalytics/snowplow/rdbloader/common/StorageTarget.scala b/...common/src/main/scala/com/snowplowanalytics/snowplow/rdbloader/common/StorageTarget.scala
@@ -12,6 +12,7 @@
  */
 package com.snowplowanalytics.snowplow.rdbloader.common
 
+import java.net.URI
 import java.util.UUID
 import java.util.Properties
 
@@ -50,6 +51,7 @@ sealed trait StorageTarget extends Product with Serializable {
 
   def blacklistTabular: Option[List[SchemaCriterion]]   // None means tabular is disabled
   def messageQueue: Option[String]
+  def sentryDsn: Option[URI]
 }
 
 object StorageTarget {
@@ -89,7 +91,8 @@ object StorageTarget {
                             sshTunnel: Option[TunnelConfig],
 
                             blacklistTabular: Option[List[SchemaCriterion]],
-                            messageQueue: Option[String])
+                            messageQueue: Option[String],
+                            sentryDsn: Option[URI])
     extends StorageTarget
 
   /**
@@ -164,14 +167,28 @@ object StorageTarget {
   case class DestinationConfig(host: String, port: Int)
 
   /** ADT representing fact that password can be either plain-text or encrypted in EC2 Parameter Store */
-  sealed trait PasswordConfig {
+  sealed trait PasswordConfig extends Product with Serializable {
     def getUnencrypted: String = this match {
-      case PlainText(plain) => plain
-      case EncryptedKey(EncryptedConfig(key)) => key.parameterName
+      case PasswordConfig.PlainText(plain) => plain
+      case PasswordConfig.EncryptedKey(EncryptedConfig(key)) => key.parameterName
+    }
+  }
+  object PasswordConfig {
+    final case class PlainText(value: String) extends PasswordConfig
+    final case class EncryptedKey(value: EncryptedConfig) extends PasswordConfig
+
+    implicit object PasswordDecoder extends Decoder[PasswordConfig] {
+      def apply(hCursor: HCursor): Decoder.Result[PasswordConfig] = {
+        hCursor.value.asString match {
+          case Some(s) => Right(PasswordConfig.PlainText(s))
+          case None => hCursor.value.asObject match {
+            case Some(_) => hCursor.value.as[EncryptedConfig].map(PasswordConfig.EncryptedKey)
+            case None => Left(DecodingFailure("password should be either plain text or reference to encrypted key", hCursor.history))
+          }
+        }
+      }
     }
   }
-  case class PlainText(value: String) extends PasswordConfig
-  case class EncryptedKey(value: EncryptedConfig) extends PasswordConfig
 
   /**
     * SSH configuration, enabling target to be loaded though tunnel
@@ -183,18 +200,6 @@ object StorageTarget {
     */
   case class TunnelConfig(bastion: BastionConfig, localPort: Int, destination: DestinationConfig)
 
-  implicit object PasswordDecoder extends Decoder[PasswordConfig] {
-    def apply(hCursor: HCursor): Decoder.Result[PasswordConfig] = {
-      hCursor.value.asString match {
-        case Some(s) => Right(PlainText(s))
-        case None => hCursor.value.asObject match {
-          case Some(_) => hCursor.value.as[EncryptedConfig].map(EncryptedKey)
-          case None => Left(DecodingFailure("password should be either plain text or reference to encrypted key", hCursor.history))
-        }
-      }
-    }
-  }
-
   /**
     * Decode Json as one of known storage targets
     *
@@ -222,6 +227,9 @@ object StorageTarget {
       .toEitherNel
       .flatMap { json => (decodeStorageTarget(json).toEitherNel, validate(client)(json).toEitherNel).parMapN { case (config, _) => config } }
 
+  implicit def uriDecoder: Decoder[URI] =
+    Decoder[String].emap(s => Either.catchOnly[IllegalArgumentException](URI.create(s)).leftMap(_.toString))
+
   implicit def redsfhitConfigDecoder: Decoder[RedshiftConfig] =
     deriveDecoder[RedshiftConfig]
 
@@ -240,9 +248,6 @@ object StorageTarget {
   implicit def parameterStoreConfigDecoder: Decoder[ParameterStoreConfig] =
     deriveDecoder[ParameterStoreConfig]
 
-  implicit def passwordConfigDecoder: Decoder[PasswordConfig] =
-    deriveDecoder[PasswordConfig]
-
   implicit def schemaCriterionConfigDecoder: Decoder[SchemaCriterion] =
     Decoder.decodeString.emap {
       s => SchemaCriterion.parse(s).toRight(s"Cannot parse [$s] as Iglu SchemaCriterion, it must have iglu:vendor/name/format/1-*-* format")