Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.7.5 #1325

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Release 5.7.5 #1325

merged 6 commits into from
Dec 4, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 4, 2023

Created by Github Actions

@snowplowcla
Copy link
Collaborator

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@colmsnowplow colmsnowplow mentioned this pull request Dec 4, 2023
Closed
@colmsnowplow colmsnowplow force-pushed the release/5.7.5 branch 2 times, most recently from 4ab4757 to ca3c660 Compare December 4, 2023 11:13
spenes
spenes reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@spenes spenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing but it might be better to create different commits for version bumps of different dependencies. I don't have very strong opinion about that but I want to mention that since this is how we do that previously.

@colmsnowplow
Copy link
Contributor

@spenes rebased as you describe

spenes
spenes approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@spenes spenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colmsnowplow
Copy link
Contributor

Apologies I had pushed before I committed the changelog fix - done now, thanks!

@colmsnowplow colmsnowplow merged commit 6c87659 into master Dec 4, 2023
13 checks passed
@colmsnowplow colmsnowplow deleted the release/5.7.5 branch December 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenes spenes spenes approved these changes

Assignees
No one assigned
Labels
cla:no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snowplowcla @colmsnowplow @spenes