Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnowplowTracker::Emitter: Make the logger configurable via a :logger option #109

Closed
wants to merge 2 commits into from

Conversation

mcls
Copy link
Contributor

@mcls mcls commented Mar 11, 2019

Currently the logger is always hard-coded and logs to STDERR. This change allows it to be configured.

PS: I also overwrite the logger in tests now, so that the output is clean and I've removed some leftover puts statements that were committed.

@snowplowcla snowplowcla added the cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. label Mar 11, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 95.011% when pulling f026b68 on mcls:mcls/config-logger into 39fcfa2 on snowplow:master.

Copy link

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@mscwilson
Copy link
Contributor

Hello again @mcls. Both of your commits in this PR have been cherry-picked into the release branch for our next release, v0.7.0.

Again, thanks for your much appreciated contribution, and apologies for taking so long to merge your work in.

@mscwilson mscwilson closed this Sep 13, 2021
@mcls
Copy link
Contributor Author

mcls commented Sep 15, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants