Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate statsd metrics are sent when loading lzo files #229

Closed
istreeter opened this issue Sep 30, 2021 · 0 comments
Closed

Duplicate statsd metrics are sent when loading lzo files #229

istreeter opened this issue Sep 30, 2021 · 0 comments

Comments

@istreeter
Copy link
Contributor

The KinesisS3Emitter has a callback function which does the statsd reporting after successfully uploading files to S3.

However, the callback is called inside a foreach loop. For lzo compression, this means it is called after the .lzo file is uploaded and also after the .lzo.index file is uploaded. Whereas we should only call it once.

I'll be honest, I've not actually tested this. This is just based on looking at the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant