Skip to content

Commit

Permalink
Scala Common Enrich: added currency fields to POJO (closes #1316)
Browse files Browse the repository at this point in the history
  • Loading branch information
fblundun committed Jan 20, 2015
1 parent 0e7e44c commit ab4c78a
Showing 1 changed file with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -196,4 +196,13 @@ class EnrichedEvent {
@BeanProperty var doc_charset: String = _
@BeanProperty var doc_width: JInteger = _
@BeanProperty var doc_height: JInteger = _
}

// Currency
@BeanProperty var tr_currency: String = _
@BeanProperty var tr_total_base: String = _
@BeanProperty var tr_tax_base: String = _
@BeanProperty var tr_shipping_base: String = _
@BeanProperty var ti_currency: String = _
@BeanProperty var ti_price_base: String = _
@BeanProperty var base_currency: String = _
}

9 comments on commit ab4c78a

@fblundun
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderdean I've made these strings because of this comment:

@BeanProperty var se_value: String = _ // Technically should be a Double but may be rendered incorrectly by Cascading with scientific notification (which Redshift can't process)

Is that right?

@alexanderdean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep correct!

@kazjote
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is there any chance to have it in master soon?

I have to deal with different currencies and not having currency code in transaction event is an issue.

@christoph-buente
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@khalidjaz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexanderdean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this milestone will likely become Release 62. We have Release 60 in test now and Release 61 is almost done.

This release will include currency conversions to a base currency using Open Exchange Rates (hence the _base fields).

@christoph-buente
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @alexanderdean for the update. Great work, we're looking forward to see this feature in a release. Any chance moves to master, so we can compile it ourselves?

@alexanderdean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No master is always the latest release.

@christoph-buente
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it what tags are made for? Nevermind, we'll fork it then.

Please sign in to comment.