Scala Hadoop Enrich: simplified validation projection code (closes #1986

)
snowplow · Jan 14, 2016 · db9a8c0 · db9a8c0
1 parent 922abb5
commit db9a8c0
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/...la-hadoop-enrich/src/main/scala/com.snowplowanalytics.snowplow.enrich.hadoop/EtlJob.scala b/...la-hadoop-enrich/src/main/scala/com.snowplowanalytics.snowplow.enrich.hadoop/EtlJob.scala
@@ -105,9 +105,8 @@ object EtlJob {
    *         Strings
    */
   def projectBads(all: List[ValidatedEnrichedEvent]): List[NonEmptyList[String]] = all
-    .map(_.swap.toOption)
-    .collect { case Some(errs) =>
-      errs
+    .collect {
+      case Failure(errs) => errs
     }
 
   /**
@@ -120,9 +119,8 @@ object EtlJob {
    * @return a (possibly empty) List of EnrichedEvents
    */
   def projectGoods(all: List[ValidatedEnrichedEvent]): List[EnrichedEvent] = all
-    .map(_.toOption)
-    .collect { case Some(gd) =>
-      gd
+    .collect {
+      case Success(gd) => gd
     }
 }